[fix] handle case where instance already exists #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
force-pushed
the
fix-instance-already-exist-error
branch
2 times, most recently
from
4205c90
to
f1eb5ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 64.84% 64.84% -0.01%
==========================================
Files 79 79
Lines 5664 5683 +19
==========================================
+ Hits 3673 3685 +12
- Misses 1718 1723 +5
- Partials 273 275 +2 ☔ View full report in Codecov by Sentry. |
rahulait
force-pushed
the
fix-instance-already-exist-error
branch
from
f8d18f9
to
3812bb9
Compare
rahulait
force-pushed
the
fix-instance-already-exist-error
branch
2 times, most recently
from
a44e517
to
2e94207
Compare
AshleyDumaine
changed the title
komer3
previously approved these changes
Nov 7, 2024
rahulait
force-pushed
the
fix-instance-already-exist-error
branch
from
b0e3b28
to
4944970
Compare
komer3
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If create instance call fails due to context timeout error, instance gets provisioned on the linode side but CAPL thinks instance is still not created. It keeps on retrying and ends up hitting [400 label must be unique] error as it cannot provision another instance with same name. This results in CAPL continuously retrying to create the instance and ending up hitting rate-limits. This PR fixes the issue by doing a GET if instance already exists and using it during next reconciles.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: